Don't attempt to set response buffer size on a committed response#5532
Merged
BalusC merged 1 commit intoeclipse-ee4j:4.0from Nov 23, 2024
Merged
Conversation
Signed-off-by: Andrew Pielage <[email protected]>
Contributor
Author
|
I am very open to changing the log level of the "skip" message, it may be better to have it at something like FINE. |
Contributor
|
I've casual exceptions like this on my webapps, thanks +1 for the Log level FINE |
Contributor
|
The existing checks all log WARN and this is OK as it signals something dodgy is going on and therefore makes the developer aware that the flow the developer was using should be fixed/adjusted/improved. E.g. sending redirect instead of forward and calling responseComplete on FacesContext if it is available. |
BalusC
approved these changes
Nov 23, 2024
This was referenced Dec 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes made to fix #5164 and #5262 causes breakages in the Jakarta EE 10 Security TCK (specifically in the "old" bit).
This is reproducible in Payara 6 and GlassFish 7 when using a Mojarra version higher than 4.0.0 (the first change was introduced in 4.0.1).
I'm not 100% certain if this is just a workaround for a dodgy flow, but it fixes the TCK.
The TCK fails because Mojarra is attempting to redirect from a login page after authentication and is attempting to set the response buffer size on the redirected request (which has been committed), causing the redirection to fail and the TCK to not find the correct content. If you refresh the page it has been authenticated, so that's working, it just specifically fails at the point of redirection because Mojarra appears to be too optimistically trying to set the response buffer size.