isErrorPage() check in RestoreViewPhase fails when thrown exception has a null message#5529
Merged
arjantijms merged 1 commit into4.0from Feb 3, 2025
Conversation
exception has a null message
This comment was marked as outdated.
This comment was marked as outdated.
mnriem
approved these changes
Nov 22, 2024
Contributor
mnriem
left a comment
mnriem
left a comment
There was a problem hiding this comment.
Are there any tests that validate all the (new) code paths?
Contributor
Author
|
Nope not yet. |
arjantijms
deleted the
mojarra_issue_5528_isErrorPage()_check_fails_when_handled_exception_has_null_message
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5528