Faces 4.1: Spec 1739 - Require firing events for @Initialized, @BeforeDestroyed, and @Destroyed for build-in scopes#5340
Merged
BalusC merged 1 commit intoeclipse-ee4j:masterfrom Oct 21, 2023
Conversation
…stroyed for build-in scopes
volosied
changed the title
BalusC
approved these changes
Oct 21, 2023
Contributor
|
Oh! It was targeted at master which is 5.0. I'll have to backport. Can you target next 4.1 work at 4.1 branch? :) |
BalusC
added a commit
that referenced
this pull request
Oct 21, 2023
Contributor
Author
|
Sorry! I'll watch out for that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jakartaee/faces#1739
Both Mojarra and MyFaces should have this implemented. Now it's required via the faces spec.
The tests should also be added back in the next TCK release for 4.1 / 5.0. See https://github.com/jakartaee/faces/pull/1741/files