feat: Improve KeyPair handling #836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use VARCHAR type for (json-serialized) usage field
keys to sign tokens are resolved from the KeyPairService
paullatzelsperger
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This PR improves the handling and management of
KeyPairsin the following aspects:usagefield for KeyPairs to indicate what they should be used forKeyPairServicenow offers a method to query for key for a specific useStsAccountanymore. Instead, they are resolved from theKeyPairServiceas well.ParticipantManifestnow can handle aSet<KeyDescriptor>, so that participant contexts can be onboarded with multiple keysWhy it does that
improvement of KeyPairs, improve security
Further notes
A possibility to specify a concrete key (by ID) when signing credentials, presentations and token may be added later
Breaking change, due to schema changes and changes in DTOs
Who will sponsor this feature?
Please @-mention the committer that will sponsor your feature.
Linked Issue(s)
Closes #835
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.