feat: improve handling of VerifiableCredentialResources #834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in order to distinguish between different credential usage types
use new factory methods, add presentation api test
paullatzelsperger
added
enhancement
jimmarino
approved these changes
Oct 21, 2025
paullatzelsperger
force-pushed
the
feat/colocated_runtimes
branch
from
0892699 to
f44f0ee
Compare
wolf4ood
approved these changes
Oct 21, 2025
This was referenced Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
this PR mainly improves the storage and handling of
VerifiableCredentialResourcesby adding ausagefield.This new field indicates what the credential is used for, i.e.
Holder,StatusList,IssuanceTracking.Whenever credentials are handled, they must be filtered by their
usagetype, e.g. onlyHoldercredentials should be used for DCP Presentation.Why it does that
avoid clashes and weird errors when the
IssuerServiceandIdentityHubare colocated in the same runtime.Further notes
to assert compatibility, I created a new test
DcpFlowAllInOneTestthat spins up a colocated runtime and that executes several test cases:this is a breaking change because a new column
usageis added to the database schemaWho will sponsor this feature?
Please @-mention the committer that will sponsor your feature.
Linked Issue(s)
Closes #827
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.