fix: correct usage of status code 200 in swagger spec #730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
| ) | ||
| Response revokeCredential(String participantContextId, String credentialId, SecurityContext context); | ||
| void revokeCredential(String participantContextId, String credentialId, SecurityContext context); |
Check notice
Code scanning / CodeQL
Useless parameter Note
bscholtes1A
force-pushed
the
fix/swagger_spec_status_codes
branch
2 times, most recently
from
04f6ade to
ef72b49
Compare
bscholtes1A
requested review from
ndr-brt,
paullatzelsperger and
wolf4ood
and removed request for
ndr-brt,
paullatzelsperger and
wolf4ood
paullatzelsperger
approved these changes
Jun 3, 2025
wolf4ood
approved these changes
Jun 3, 2025
bscholtes1A
force-pushed
the
fix/swagger_spec_status_codes
branch
3 times, most recently
from
75e1d48 to
f44573f
Compare
ndr-brt
approved these changes
Jun 9, 2025
Member
|
@bscholtes1A once CI will be green we can merge |
bscholtes1A
force-pushed
the
fix/swagger_spec_status_codes
branch
3 times, most recently
from
8044b29 to
24b087e
Compare
bscholtes1A
force-pushed
the
fix/swagger_spec_status_codes
branch
from
24b087e to
ec4449b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Use status code 204 in swagger spec for APIs that does not return anything.
Why it does that
Fix.
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Who will sponsor this feature?
Please @-mention the committer that will sponsor your feature.
Linked Issue(s)
Closes #731
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.