Skip to content

Conversation

@paullatzelsperger
Copy link
Member

@paullatzelsperger paullatzelsperger commented May 28, 2025

What this PR changes/adds

this PR changes the following things:

  • CredentialObject now has an id property
  • CredentialOfferMessage can contain either the fully-fledged CredentialObject, or just an {"id": "..."} object.
  • CredentiaRequestMessage contains only a list of {"id": "..."} objects referencing the CredentialObject

Why it does that

Compliance with latest TCK changes

Further notes

  • the Issuer Admin API was also changed such that the credential offer endpoint takes an array of IDs instead of a CredentialDescriptor.

Who will sponsor this feature?

Please @-mention the committer that will sponsor your feature.

Linked Issue(s)

Closes # <-- insert Issue number if one exists

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@paullatzelsperger paullatzelsperger added dcp breaking-change Will require manual intervention for version update labels May 28, 2025
@paullatzelsperger paullatzelsperger force-pushed the feat/adapt_to_latest_dcp_tck branch from 2ecc9ac to 6d2e535 Compare May 28, 2025 11:53
@paullatzelsperger paullatzelsperger added the enhancement New feature or request label May 28, 2025
@paullatzelsperger paullatzelsperger marked this pull request as draft May 28, 2025 12:02
@paullatzelsperger paullatzelsperger force-pushed the feat/adapt_to_latest_dcp_tck branch from 1f236ca to bbb3bb1 Compare May 28, 2025 12:21
@paullatzelsperger paullatzelsperger marked this pull request as ready for review May 28, 2025 12:33
@paullatzelsperger paullatzelsperger merged commit 96dac29 into eclipse-edc:main May 28, 2025
17 checks passed
@paullatzelsperger paullatzelsperger deleted the feat/adapt_to_latest_dcp_tck branch May 28, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change Will require manual intervention for version update dcp enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants