fix: repair generated swagger apis #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

bscholtes1A merged 1 commit into eclipse-edc:main from bscholtes1A:fix/repair_swagger_spec_generation

Jun 2, 2025

Contributor

bscholtes1A commented May 5, 2025

What this PR changes/adds

Make generated Swagger spec valid after generation.

Why it does that

Fix swagger.

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Who will sponsor this feature?

Please @-mention the committer that will sponsor your feature.

Linked Issue(s)

Closes #718

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

bscholtes1A added bug api labels

bscholtes1A self-assigned this

bscholtes1A force-pushed the fix/repair_swagger_spec_generation branch from 7dd636f to 960edce Compare

May 5, 2025 08:23

github-advanced-security bot found potential problems

View reviewed changes

.../eclipse/edc/identityhub/api/verifiablecredentials/v1/unstable/VerifiableCredentialsApi.java Dismissed Show dismissed Hide dismissed

.../eclipse/edc/identityhub/api/verifiablecredentials/v1/unstable/VerifiableCredentialsApi.java Dismissed Show dismissed Hide dismissed

.../eclipse/edc/identityhub/api/verifiablecredentials/v1/unstable/VerifiableCredentialsApi.java

    
                          }

                  )

                  Collection<VerifiableCredentialResource> queryCredentialsByType(String type, SecurityContext securityContext);

                  Collection<VerifiableCredentialResource> queryCredentialsByType(String participantContextId, String type, SecurityContext securityContext);

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'participantContextId' is never used.

.../eclipse/edc/identityhub/api/verifiablecredentials/v1/unstable/VerifiableCredentialsApi.java Dismissed Show dismissed Hide dismissed

...g/eclipse/edc/issuerservice/api/admin/credentials/v1/unstable/IssuerCredentialsAdminApi.java

    
                  Response suspendCredential(String participantContextId, String credentialId);

                  @Operation(description = "Resumes a credential with the given ID for the given participant. Resumed credentials will be removed from the Revocation List.",

                          operationId = "resumeCredential",

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'participantContextId' is never used.

...g/eclipse/edc/issuerservice/api/admin/credentials/v1/unstable/IssuerCredentialsAdminApi.java

    
                  Response suspendCredential(String participantContextId, String credentialId);

                  @Operation(description = "Resumes a credential with the given ID for the given participant. Resumed credentials will be removed from the Revocation List.",

                          operationId = "resumeCredential",

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'credentialId' is never used.

...g/eclipse/edc/issuerservice/api/admin/credentials/v1/unstable/IssuerCredentialsAdminApi.java

    
                  Response resumeCredential(String participantContextId, String credentialId);

                  @Operation(description = "Checks the revocation status of a credential with the given ID for the given participant.",

                          operationId = "checkCredentialStatus",

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'participantContextId' is never used.

...g/eclipse/edc/issuerservice/api/admin/credentials/v1/unstable/IssuerCredentialsAdminApi.java

    
                  Response resumeCredential(String participantContextId, String credentialId);

                  @Operation(description = "Checks the revocation status of a credential with the given ID for the given participant.",

                          operationId = "checkCredentialStatus",

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'credentialId' is never used.

bscholtes1A requested review from paullatzelsperger and wolf4ood and removed request for paullatzelsperger

May 5, 2025 11:08

paullatzelsperger reviewed

View reviewed changes

...dc/identityhub/api/verifiablecredentials/v1/unstable/VerifiableCredentialsApiController.java Show resolved Hide resolved

.../eclipse/edc/identityhub/api/verifiablecredentials/v1/unstable/VerifiableCredentialsApi.java Show resolved Hide resolved

bscholtes1A force-pushed the fix/repair_swagger_spec_generation branch from 960edce to 68fa48a Compare

May 16, 2025 08:46

github-advanced-security bot found potential problems

View reviewed changes

...rc/main/java/org/eclipse/edc/identityhub/api/didmanagement/v1/unstable/DidManagementApi.java

    
                          }

                  )

                  void publishDid(DidRequestPayload didRequestPayload, SecurityContext securityContext);

                  void publishDid(String participantContextId, DidRequestPayload didRequestPayload, SecurityContext securityContext);

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'participantContextId' is never used.

...rc/main/java/org/eclipse/edc/identityhub/api/didmanagement/v1/unstable/DidManagementApi.java

    
                          }

                  )

                  void unpublishDid(DidRequestPayload didRequestPayload, SecurityContext securityContext);

                  void unpublishDid(String participantContextId, DidRequestPayload didRequestPayload, SecurityContext securityContext);

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'participantContextId' is never used.

...rc/main/java/org/eclipse/edc/identityhub/api/didmanagement/v1/unstable/DidManagementApi.java

    
                          }

                  )

                  Collection<DidDocument> queryDids(QuerySpec querySpec, SecurityContext securityContext);

                  Collection<DidDocument> queryDids(String participantContextId, QuerySpec querySpec, SecurityContext securityContext);

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'participantContextId' is never used.

...rc/main/java/org/eclipse/edc/identityhub/api/didmanagement/v1/unstable/DidManagementApi.java

    
                          }

                  )

                  String getDidState(DidRequestPayload request, SecurityContext securityContext);

                  String getDidState(String participantContextId, DidRequestPayload request, SecurityContext securityContext);

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'participantContextId' is never used.

...rc/main/java/org/eclipse/edc/identityhub/api/didmanagement/v1/unstable/DidManagementApi.java

    
                          }

                  )

                  void addDidEndpoint(String did, Service service, boolean autoPublish, SecurityContext securityContext);

                  void addDidEndpoint(String participantContextId, String did, Service service, boolean autoPublish, SecurityContext securityContext);

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'participantContextId' is never used.

...rc/main/java/org/eclipse/edc/identityhub/api/didmanagement/v1/unstable/DidManagementApi.java

    
                          }

                  )

                  void deleteDidEndpoint(String did, String serviceId, boolean autoPublish, SecurityContext securityContext);

                  void deleteDidEndpoint(String participantContextId, String did, String serviceId, boolean autoPublish, SecurityContext securityContext);

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'participantContextId' is never used.

...pi/src/main/java/org/eclipse/edc/identityhub/api/keypair/v1/unstable/KeyPairResourceApi.java

    
                          }

                  )

                  KeyPairResource getKeyPair(String id, SecurityContext securityContext);

                  KeyPairResource getKeyPair(String participantContextId, String id, SecurityContext securityContext);

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'participantContextId' is never used.

...pi/src/main/java/org/eclipse/edc/identityhub/api/keypair/v1/unstable/KeyPairResourceApi.java

    
                          }

                  )

                  void activateKeyPair(String keyPairResourceId, SecurityContext securityContext);

                  void activateKeyPair(String participantContextId, String keyPairResourceId, SecurityContext securityContext);

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'participantContextId' is never used.

...pi/src/main/java/org/eclipse/edc/identityhub/api/keypair/v1/unstable/KeyPairResourceApi.java

    
                          }

                  )

                  void rotateKeyPair(String id, KeyDescriptor newKey, long duration, SecurityContext securityContext);

                  void rotateKeyPair(String participantContextId, String id, KeyDescriptor newKey, long duration, SecurityContext securityContext);

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'participantContextId' is never used.

...pi/src/main/java/org/eclipse/edc/identityhub/api/keypair/v1/unstable/KeyPairResourceApi.java

    
                          }

                  )

                  void revokeKeyPair(String id, KeyDescriptor newKey, SecurityContext securityContext);

                  void revokeKeyPair(String participantContextId, String id, KeyDescriptor newKey, SecurityContext securityContext);

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'participantContextId' is never used.

bscholtes1A requested a review from paullatzelsperger

May 19, 2025 09:37

ndr-brt mentioned this pull request

Fix Response codes on IdentityHub open-API specs Think-iT-Labs/edc-connector-client#375

Open

1 task

github-actions bot commented May 27, 2025

This pull request is stale because it has been open for 7 days with no activity.

github-actions bot added the stale label

paullatzelsperger approved these changes

View reviewed changes

github-actions bot removed the stale label


          fix: repair generated swagger apis

a53d46a

bscholtes1A force-pushed the fix/repair_swagger_spec_generation branch from 68fa48a to a53d46a Compare

June 2, 2025 08:55

bscholtes1A merged commit dee0bb8 into eclipse-edc:main

16 of 17 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels