fix: use mapper embedding date-time in LocalStatusListCredentialPublisherExtension #711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bscholtes1A
changed the title
LocalStatusListCredentialPublisherExtension
bscholtes1A
changed the title
| portMappingRegistry.register(new PortMapping(STATUS_LIST, config.port(), config.path())); | ||
|
|
||
| webServer.registerResource(STATUS_LIST, new StatusListCredentialController(store, context.getMonitor(), new ObjectMapper())); | ||
| webServer.registerResource(STATUS_LIST, new StatusListCredentialController(store, monitor, JacksonJsonLd.createObjectMapper())); |
Member
There was a problem hiding this comment.
the object mapper should not be "hard-coded", better to use:
@Inject
private TypeManager typeManager;
public void initialize(ServiceExtensionContext context){
//...
var objectMapper = typeManager.getMapper(JSON_LD);
//...
}
bscholtes1A
force-pushed
the
fix/710_mapper_datetime_module_localstatuscredentialpublisher
branch
from
c4bab65 to
eed3238
Compare
paullatzelsperger
approved these changes
Apr 17, 2025
wolf4ood
reviewed
Apr 17, 2025
Comment on lines
66
to
78
| webServer.registerResource(STATUS_LIST, new StatusListCredentialController(store, context.getMonitor(), new ObjectMapper())); | ||
| webServer.registerResource(STATUS_LIST, new StatusListCredentialController(store, monitor, objectMapper)); |
Contributor
There was a problem hiding this comment.
I think it's better to pass or a Supplier<ObjectMapper> or the type manager and the and the JSON_LD key to the StatusListCredentialController. We had strange behavior in the past where the JSON_LD was not registered yet in the TypeManager and the get returned the default one, which probably it's not the expected one
bscholtes1A
force-pushed
the
fix/710_mapper_datetime_module_localstatuscredentialpublisher
branch
from
eed3238 to
100154a
Compare
…ialPublisherExtension
bscholtes1A
force-pushed
the
fix/710_mapper_datetime_module_localstatuscredentialpublisher
branch
from
100154a to
db246bd
Compare
wolf4ood
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Use mapper including date/time modules in
LocalStatusListCredentialPublisherExtension.Why it does that
Fix error during mapping to VC.
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Who will sponsor this feature?
@bscholtes1A
Linked Issue(s)
Closes #710
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.