feat: add signing capability to credential generator #654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
force-pushed
the
feat/add_signing_capabilities_to_credential_generator
branch
2 times, most recently
from
633f6c8 to
88fce67
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...n/java/org/eclipse/edc/issuerservice/issuance/generator/CredentialGeneratorRegistryImpl.java
Fixed
Show fixed
Hide fixed
paullatzelsperger
force-pushed
the
feat/add_signing_capabilities_to_credential_generator
branch
from
88fce67 to
a43d425
Compare
wolf4ood
approved these changes
Mar 6, 2025
paullatzelsperger
deleted the
feat/add_signing_capabilities_to_credential_generator
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
in addition to generate new credentials, the
CredentialGeneratorRegistry(and by extension: theCredentialGenerator) are now capable of signing existingVerifiableCredentialobjects.Why it does that
this will be necessary when updating holder credentials, for example after a
credentialStatusobject was added. This happens at a later time, after the credential was generated.Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Who will sponsor this feature?
Please @-mention the committer that will sponsor your feature.
Linked Issue(s)
Closes # <-- insert Issue number if one exists
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.