feat: validate incoming CredentialMessage types and formats #631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolf4ood
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
this PR adds validation for the credential types and serialization formats of an incoming
CredentialMessage.Sending credentials, where the type(s) or serialization formats do not correspond to a previously made
HolderCredentialRequestis not allowed and will result in a HTTP 403 Unauthorized.Why it does that
prevent malicious issuers
Further notes
CredentialWriteris doing. at some point we might consider splitting it up (which would require another aggregate service), or at least renaming it.@DisplayNames to the Storage API e2e testWho will sponsor this feature?
Please @-mention the committer that will sponsor your feature.
Linked Issue(s)
Closes #581
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.