feat: expose StorageAPI and PresentationAPI on same web context #627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
added
enhancement
paullatzelsperger
changed the title
paullatzelsperger
force-pushed
the
feat/merge_dcp_apis
branch
from
aea15ab to
7b2b8a9
Compare
paullatzelsperger
force-pushed
the
feat/merge_dcp_apis
branch
from
0d2d176 to
1f45fc5
Compare
jimmarino
approved these changes
Feb 26, 2025
wolf4ood
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
this PR exposes the Storage API and the Credentials API on the same web context called
credentials.to that end, the configurations were merged into
web.http.credentials.port/path, and a dedicatedcredentials-api-configurationwas introduced.Important note: the Storage API is now available under
/v1/.../credentialsinstead of/v1alpha/.../credentials, because the base URL paths for it and the PResentationAPI must be identical.Why it does that
the holder DID document only contains one service entry
CredentialServiceat which both APIs must be available.Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Who will sponsor this feature?
Please @-mention the committer that will sponsor your feature.
Linked Issue(s)
Closes #626
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.