refactor: move STS modules to IdentityHub #623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
added
enhancement
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| @Provider | ||
| public StsClientTokenGeneratorService clientTokenService(ServiceExtensionContext context) { |
Check notice
Code scanning / CodeQL
Useless parameter Note
| } | ||
|
|
||
|
|
||
| public Builder id(String id) { |
Check notice
Code scanning / CodeQL
Missing Override annotation Note
| * @param parameters Optional generator arguments, such as a salt value. Not all generators require this value. | ||
| * @return a randomly generated client secret. | ||
| */ | ||
| String generateClientSecret(@Nullable Object parameters); |
Check notice
Code scanning / CodeQL
Useless parameter Note
paullatzelsperger
force-pushed
the
refactor/always_use_embedded_sts
branch
from
b42e3ff to
f0ca12e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This PR moves most STS modules into IdentityHub and welds STS directly into IdentityHub and IssuerService.
the
EmbeddedSecureTokenServicefrom the connector repo was removed completely, since IdentityHub/IssuerService usea participant-context-aware variant of it.
Why it does that
Briefly state why the change was necessary.
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Who will sponsor this feature?
Please @-mention the committer that will sponsor your feature.
Linked Issue(s)
Closes # <-- insert Issue number if one exists
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.