feat: implement holder credential-request state machine #602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...eclipse/edc/identityhub/core/services/verifiablecredential/CredentialRequestServiceImpl.java
Fixed
Show fixed
Hide fixed
...eclipse/edc/identityhub/core/services/verifiablecredential/CredentialRequestServiceImpl.java
Fixed
Show fixed
Hide fixed
wolf4ood
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
this PR adds statemachine capabilities to the
CredentialRequestServiceImpl.whenever a
HolderCredentialRequestis in a state other thanISSUED, the state machine attempts to restart/resume the credential request.When in
REQUESTEDstate, the state machine sends aCredentialStatusRequestto the Issuer to get the current state.Why it does that
robustness
Further notes
identity-hub-coremoduleWho will sponsor this feature?
Please @-mention the committer that will sponsor your feature.
Linked Issue(s)
Closes #588
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.