Skip to content

Conversation

@wolf4ood
Copy link
Contributor

What this PR changes/adds

Add participant context in the IssuanceProcess. To not confuse with the participantId the field has been

named to issuerContextId but refers to the ParticipantContext id of the IH.

Why it does that

Briefly state why the change was necessary.

Further notes

Package renaming in sq-credential-definition-store which contained a wrong attestationdefinition references

Who will sponsor this feature?

Please @-mention the committer that will sponsor your feature.

Linked Issue(s)

Closes #596

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@wolf4ood wolf4ood self-assigned this Feb 18, 2025
@wolf4ood wolf4ood added the enhancement New feature or request label Feb 18, 2025
@wolf4ood wolf4ood force-pushed the feat/596_issuance_process_participant_context_integration branch from 16702e6 to 87e0583 Compare February 18, 2025 11:12
@wolf4ood wolf4ood force-pushed the feat/596_issuance_process_participant_context_integration branch from 87e0583 to 1d56e6f Compare February 18, 2025 11:26
@wolf4ood wolf4ood marked this pull request as ready for review February 18, 2025 11:32
@wolf4ood wolf4ood requested review from jimmarino and paullatzelsperger and removed request for paullatzelsperger February 18, 2025 11:32
Copy link
Member

@paullatzelsperger paullatzelsperger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just wanted to note that in IH, all resources that have a participantContextId extend ParticipantResource.

We can merge as-is, but we should look whether we can unify this in the near future.

@paullatzelsperger paullatzelsperger merged commit eb40fd6 into eclipse-edc:main Feb 18, 2025
18 checks passed
@wolf4ood wolf4ood deleted the feat/596_issuance_process_participant_context_integration branch December 19, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IssuanceProcess integration with participant context

3 participants