feat: add Credential Request endpoints (IdentityApi) #590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
force-pushed
the
add_credentialrequest_endpoints
branch
from
8f5c79a to
88bd15b
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| content = @Content(array = @ArraySchema(schema = @Schema(implementation = ApiErrorDetail.class)), mediaType = "application/json")) | ||
| } | ||
| ) | ||
| HolderCredentialRequestDto getCredentialRequest(String participantContextId, String issuanceProcessId, SecurityContext securityContext); |
Check notice
Code scanning / CodeQL
Useless parameter Note
|
|
||
| @Override | ||
| public IssuerCredentialIssuanceProcess build() { | ||
| public IssuanceProcess build() { |
Check notice
Code scanning / CodeQL
Missing Override annotation Note
| } | ||
|
|
||
| @Provider(isDefault = true) | ||
| public CredentialRequestService createDefaultCredentialRequestService(ServiceExtensionContext context) { |
Check notice
Code scanning / CodeQL
Useless parameter Note
| * @param typesAndFormats A map containing credential-type - credential-format entries | ||
| * @return A ServiceResult containing the issuer-assigned process ID, or a failure otherwise. | ||
| */ | ||
| ServiceResult<String> initiateRequest(String issuerDid, String requestId, Map<String, String> typesAndFormats); |
Check notice
Code scanning / CodeQL
Useless parameter Note
| * @param typesAndFormats A map containing credential-type - credential-format entries | ||
| * @return A ServiceResult containing the issuer-assigned process ID, or a failure otherwise. | ||
| */ | ||
| ServiceResult<String> initiateRequest(String issuerDid, String requestId, Map<String, String> typesAndFormats); |
Check notice
Code scanning / CodeQL
Useless parameter Note
| * @param typesAndFormats A map containing credential-type - credential-format entries | ||
| * @return A ServiceResult containing the issuer-assigned process ID, or a failure otherwise. | ||
| */ | ||
| ServiceResult<String> initiateRequest(String issuerDid, String requestId, Map<String, String> typesAndFormats); |
Check notice
Code scanning / CodeQL
Useless parameter Note
wolf4ood
approved these changes
Feb 14, 2025
jimmarino
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
this PR adds two endpoints to the IdentityApi, specifically the VerifiableCredentials API to initiate credential requests, and to obtain
credential requests.
Why it does that
to be able to initiate credential requests and to get them later
Further notes
IssuerCredentialIssuanceProcess->IssuanceProcess), because on the holder side we'll call it "CredentialRequest", on the issuer side we'll call it "IssuanceProcess"Who will sponsor this feature?
Please @-mention the committer that will sponsor your feature.
Linked Issue(s)
Closes #586
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.