feat: implement StorageApi + validator #572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
.../storage-api/src/main/java/org/eclipse/edc/identityhub/api/storage/StorageApiController.java
Fixed
Show fixed
Hide fixed
.../storage-api/src/main/java/org/eclipse/edc/identityhub/api/storage/StorageApiController.java
Fixed
Show fixed
Hide fixed
paullatzelsperger
force-pushed
the
feat/implement_storage_api
branch
from
640992c to
a782fbc
Compare
|
|
||
| participantContextId = onEncoded(participantContextId).orElseThrow(InvalidRequestException::new); | ||
|
|
||
| var credentialMessage = protocolRegistry.forContext(DCP_SCOPE_V_1_0).transform(credentialMessageJson, CredentialMessage.class).orElseThrow(InvalidRequestException::new); |
Check notice
Code scanning / CodeQL
Unread local variable Note
|
|
||
| var credentialMessage = protocolRegistry.forContext(DCP_SCOPE_V_1_0).transform(credentialMessageJson, CredentialMessage.class).orElseThrow(InvalidRequestException::new); | ||
|
|
||
| var issuerScopes = selfIssuedTokenVerifier.verify(authtoken, participantContextId).orElseThrow(f -> new AuthenticationFailedException("ID token verification failed: %s".formatted(f.getFailureDetail()))); |
Check notice
Code scanning / CodeQL
Unread local variable Note
paullatzelsperger
force-pushed
the
feat/implement_storage_api
branch
from
f78fdd3 to
e2fbefc
Compare
wolf4ood
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This PR adds the Storage API + Controller + JSON-LD Validator
Why it does that
Implement DCP Issuance
Further notes
storage-apiandpresentation-apihave been moved into:extensions:protocols:dcp:dcp-identityhub, to have symmetry withdcp-issuer.Who will sponsor this feature?
Please @-mention the committer that will sponsor your feature.
Linked Issue(s)
Closes #569
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.