feat: implements credential definition vertical #555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...ain/java/org/eclipse/edc/issuerservice/defaults/store/InMemoryCredentialDefinitionStore.java
Fixed
Show fixed
Hide fixed
wolf4ood
force-pushed
the
feat/552_credential_definition_vertical
branch
3 times, most recently
from
3d216d9 to
e99b5ac
Compare
Member
paullatzelsperger
left a comment
paullatzelsperger
left a comment
There was a problem hiding this comment.
some minor comments inline.
...java/org/eclipse/edc/issuerservice/spi/credentialdefinition/CredentialDefinitionService.java
Show resolved
Hide resolved
...in/java/org/eclipse/edc/identityhub/spi/issuance/credentials/model/CredentialDefinition.java
Outdated
Show resolved
Hide resolved
...ssuerservice/store/sql/credentialdefinition/schema/postgres/CredentialDefinitionMapping.java
Outdated
Show resolved
Hide resolved
wolf4ood
force-pushed
the
feat/552_credential_definition_vertical
branch
from
c2a341a to
0ac2d3e
Compare
paullatzelsperger
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Implements credential definition vertical:
CredentialDefinitionServiceCredentialDefinitionStore(with base tests)Why it does that
Credential definitions ddministration
Further notes
An initial implementation of
InMemoryAttestationDefinitionStorewas provided in this PR without testing.The
CredentialDefinitionhas anidnow which is used for identifying aCredentialDefinitionbutthe implementations of
CredentialDefinitions store has to guarantee that thecredentialTypeis uniqueThe full vertical implementation will be done in #537
Who will sponsor this feature?
Please @-mention the committer that will sponsor your feature.
Linked Issue(s)
Closes #552
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.