feat: validate 'jti' claims in AccessTokenVerifier
#481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
force-pushed
the
feat/use_jti_validation_service
branch
from
64b4acf to
3c6f187
Compare
ndr-brt
approved these changes
Oct 22, 2024
| var scopeIsPresentRule = new ClaimIsPresentRule(ACCESS_TOKEN_SCOPE_CLAIM); | ||
| registry.addRule(DCP_ACCESS_TOKEN_CONTEXT, scopeIsPresentRule); | ||
|
|
||
| if (context.getSetting(ACCESSTOKEN_JTI_VALIDATION_ACTIVATE, false)) { |
Member
There was a problem hiding this comment.
false could be extracted as a constant and used also in the @Setting annotation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
add validation for the JWT Token IDs (
jticlaim) when verifying Access tokens.to do that, the
JtiValidationRulehas been registered for the"dcp-access-token"validation context.Note that by default this check is deactivated to avoid unexpected breakages in existing applications.
set
edc.iam.accesstoken.jti.validation=trueto enable it.Why it does that
protection against replay attacks
Linked Issue(s)
Closes eclipse-edc/Connector#3749
DEPENDS ON eclipse-edc/Connector#4560
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.