chore: align activate-key with D-R #451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add KeyPairResource to DidDocument only upon activation fix tests
jimmarino
approved these changes
Sep 11, 2024
wolf4ood
approved these changes
Sep 11, 2024
ligaz
added a commit
to ligaz/MinimumViableDataspace
that referenced
this pull request
Sep 12, 2024
paullatzelsperger
pushed a commit
to eclipse-edc/MinimumViableDataspace
that referenced
this pull request
Sep 13, 2024
Fix `ih_schema.sql` to comply with eclipse-edc/IdentityHub#451
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Aligns the "active-key" operation with the decision record
Why it does that
Briefly state why the change was necessary.
Further notes
KeyPairActivatedevent (and associated methods), which is consumed by theDidDocumentServicekeyContextfield to theKeyPairResource(and the associated DB schema) to track the "context" of the key, e.g."JsonWebKey2020"KeyPairStates#ACTIVEtoKeyPairStates#ACTIVATEDfor consistencyPArticipantContextEventCoordinatoremits a warning log if a participant is added and activated, but its only key is in the"inactive"stateKeyPairService: when a key is added in theactivestate, theactivateKeymethod is invoked in the same transactionDidDocumentServicereacts to theKeyPairActivatedevent instead ofKeyPairAddedLinked Issue(s)
Closes # <-- insert Issue number if one exists
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.