chore: deprecate resolution api context #432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
force-pushed
the
chore/deprecate_resolution_api_context
branch
from
b55ef72 to
39d686c
Compare
ndr-brt
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
deprecates the
resolutionapi context and replaces all occurrences withpresentation. ifweb.http.presentation.*is configured, that overridesresolution. if onlyresolutionis configured, then a warning is issued.Why it does that
consistent naming.
Linked Issue(s)
Closes #431
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.