feat: enable participant context in the DCP identity service #5298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolf4ood
force-pushed
the
feat/5295_dcp_identity_participant_context
branch
3 times, most recently
from
be9ea1c to
7b85ff9
Compare
wolf4ood
force-pushed
the
feat/5295_dcp_identity_participant_context
branch
from
7b85ff9 to
cce0d40
Compare
wolf4ood
changed the title
wolf4ood
added
the
breaking-change
| public static final String JSON_2020_SIGNATURE_SUITE = "JsonWebSignature2020"; | ||
| public static final long DEFAULT_CLEANUP_PERIOD_SECONDS = 60; | ||
| @Setting(description = "DID of the participant") | ||
| private static final String ISSUER_ID_KEY = "edc.iam.issuer.id"; |
Member
There was a problem hiding this comment.
i'm wondering if issuer is the correct term, considering we now have an IssuerService and that might get a bit confusing....
Maybe we could deprecate this, and add something like edc.iam.connector.did or something?
Contributor
Author
There was a problem hiding this comment.
Yeah it's not super clear, also it could make sense to use the edc.participant.id to have a single setting for the id
Contributor
Author
There was a problem hiding this comment.
In case i would defer this in a separated PR wdyt?
paullatzelsperger
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
enable participant context in the DCP identity service:
edc.iam.issuer.idis not loaded at boot time but derived fromParticipantContextConfigwhen needed at runtime.TokenValidationActionhave been changed to receive theparticipantContextIdin inputAudienceValidationRulehas been moved intoSelfIssueIdTokenValidationActionas runtime check using the above mechanism.VerifiableCredentialValidationServiceandPresentationVerifierhave been changed to receive in input theaudiencewhen checking the VP.Why it does that
Briefly state why the change was necessary.
Further notes
Breaking change only at SPI layer
Who will sponsor this feature?
Please @-mention the committer that will sponsor your feature.
Linked Issue(s)
Closes #5295
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.