fix: added binding attribute to ProtocolVersion #5151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelmag110
requested review from
juliapampus,
ndr-brt and
ronjaquensel
as code owners
wolf4ood
approved these changes
Aug 1, 2025
Contributor
wolf4ood
left a comment
wolf4ood
left a comment
There was a problem hiding this comment.
@rafaelmag110 lgtm, just rebase with main
rafaelmag110
force-pushed
the
protocolversion_binding
branch
from
01d0422 to
b3a91c2
Compare
jimmarino
approved these changes
Aug 1, 2025
ronjaquensel
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Adds missing binding attribute to ProtocolVersion.
Why it does that
Compliance with DSP 2025-1.
Further notes
This should only be added after the dsp-tck is changed to a version with the added check for the binding.
Also added the metadata package to the embedded comp tests runtime, as it was missing.
Who will sponsor this feature?
@wolf4ood Mind having a look?
Linked Issue(s)
Closes #5148