fix: fixes DataAddress updates on InMemoryAssetIndex #5118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
thanks for this PR, seems that some tests are still failing |
Contributor
Author
|
@wolf4ood I'm sorry about that. Should be good to go now. |
ndr-brt
pushed a commit
that referenced
this pull request
Jul 24, 2025
* fix: fixes DataAddress updates on InMemoryAssetIndex * ignoring createdAt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Fixes data address updates on the
InMemoryAssetIndexFurther notes
Took the liberty to adapt some existing update tests as those were not actually updating the reference - they would pass even if you removed the
assetIndex.update()instruction.Who will sponsor this feature?
@wolf4ood? Should be a quick one 🙏
Linked Issue(s)
Closes #5117