fix: Improve BitString class (url-decoder, multibase) #5065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
added
bug
jimmarino
approved these changes
Jun 23, 2025
wolf4ood
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This PR does two things:
BitString.Parserslightly more intelligent in that it automatically uses a Base64UrlDecode without padding if the encoded list is prefixed with the"u"characterwriteMultibasemethod to theBitString.Writerwhich preprends the"u"character upon encoding.Why it does that
convenient use of multibase encoding and Base64 decoding
Further notes
in the
BitstringStatusListRevocationServiceI removed the section of code that previously handled the different Base64 prefixes. Those were moved to theBitString.ParserWho will sponsor this feature?
Please @-mention the committer that will sponsor your feature.
Linked Issue(s)
Closes #5047
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.