fix: avoid infinite loop on DataPlaneManager #4954
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Avoid infinite loop in
DataPlaneManagerHow:
entityReloadfeature added on theProcessRetrybecomes unnecessary because the "completion" handling happens outside of the retry loop, so it has been removed altogetherTransferServicevalidation returns aResultand not aStatusResult, theProcessimplementations have been changed to make them accept every result type that extendsAbstractResultBooleantype from the result type of the validation, as it was never evaluated. when the result is successful it means that the validation went through, if it is failed, well... :)Why it does that
fix bug
Further notes
TransferProcessHttpClientIntegrationTestfor different reasons:callback-static-endpointmodule to the bom, I feel like it slipped outWho will sponsor this feature?
Please @-mention the committer that will sponsor your feature.
Linked Issue(s)
Closes #4874
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.