Skip to content

Conversation

@ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Apr 29, 2025

What this PR changes/adds

Avoid infinite loop in DataPlaneManager

How:

  • separate transfer "validation" and "transfer", because the retry mechanism on starting a transfer should work only on validation, once the transfer is started, it makes no sense to retry running automatically, because it could fail after some time and this definitely needs to be managed at an higher level
  • by doing that, the entityReload feature added on the ProcessRetry becomes unnecessary because the "completion" handling happens outside of the retry loop, so it has been removed altogether
  • since the TransferService validation returns a Result and not a StatusResult, the Process implementations have been changed to make them accept every result type that extends AbstractResult
  • removed the Boolean type from the result type of the validation, as it was never evaluated. when the result is successful it means that the validation went through, if it is failed, well... :)

Why it does that

fix bug

Further notes

  • removed TransferProcessHttpClientIntegrationTest for different reasons:
    • they were testing something that's already well covered e2e
    • they were over complicated
    • they were actually not testing the HTTP client, but the embedded one 🥹
  • added callback-static-endpoint module to the bom, I feel like it slipped out

Who will sponsor this feature?

Please @-mention the committer that will sponsor your feature.

Linked Issue(s)

Closes #4874

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added bug Something isn't working dpf Feature related to the Data Plane Framework labels Apr 29, 2025
@ndr-brt ndr-brt force-pushed the 4878-infinite-loop branch 2 times, most recently from 1755589 to c8b0b5a Compare April 29, 2025 15:35
@ndr-brt ndr-brt requested a review from bscholtes1A as a code owner April 29, 2025 15:35
@ndr-brt ndr-brt force-pushed the 4878-infinite-loop branch 4 times, most recently from e16aa86 to b46ca6e Compare April 30, 2025 08:10
@ndr-brt ndr-brt force-pushed the 4878-infinite-loop branch from b46ca6e to 91d52fb Compare May 5, 2025 06:57
@ndr-brt ndr-brt merged commit 985ed9e into eclipse-edc:main May 5, 2025
19 checks passed
@ndr-brt ndr-brt deleted the 4878-infinite-loop branch May 5, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working dpf Feature related to the Data Plane Framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Infinite retry loop in Data Flow's RECEIVED state processing

3 participants