fix: add null destinationAddress check in DataPlaneInstance #4939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
reviewed
Apr 22, 2025
...st/java/org/eclipse/edc/connector/dataplane/selector/spi/instance/DataPlaneInstanceTest.java
Outdated
Show resolved
Hide resolved
bscholtes1A
force-pushed
the
fix/4933-npe_dataplaneinstance_can_provision_null_destination
branch
from
74e7a6a to
7c3148d
Compare
ndr-brt
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Add null check on
destinationaddress inDataPlaneInstance.Why it does that
Prevent NPE to be thrown in case
destinationis null which is a valid use-case for pull transfers.Linked Issue(s)
Closes #4933
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.