chore: remove authentication from DSP versions endpoint #4938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronjaquensel
force-pushed
the
chore/4918-unauthenticated-dsp-versions-endpoint
branch
from
6adaba7 to
8074b1a
Compare
wolf4ood
approved these changes
Apr 23, 2025
ndr-brt
approved these changes
Apr 23, 2025
|
|
||
| @Override | ||
| public ServiceResult<ProtocolVersions> getAll(TokenRepresentation tokenRepresentation) { | ||
| return tokenValidator.verify(tokenRepresentation, RequestVersionPolicyContext::new) |
Member
There was a problem hiding this comment.
is this RequestVersionPolicyContext not used anymore right? 🪓
Contributor
Author
There was a problem hiding this comment.
good point! other than registration of scopes/policy contexts doesn't seem to be used anywhere else. Since thematically it fits to this PR, I'll do so right away 🪓
Contributor
Author
There was a problem hiding this comment.
though I just noticed that it is also registered on the dispatchers. Since older version still would have the versions endpoint authenticated, maybe it would make sense to leave it for now
ronjaquensel
deleted the
chore/4918-unauthenticated-dsp-versions-endpoint
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Removes the authentication check from the DSP versions endpoint.
Why it does that
In
2025/1, the version endpoint must be unauthenticated.Further notes
I did not make any changes to the dispatchers, i.e. the authorization header will be set also on outgoing
ProtocolVersionRequestMessages. I think this makes sense for now, as older versions would still have the versions endpoint authenticated. Could be refactored at a later point to not set the authorization header for version requests.Who will sponsor this feature?
me
Linked Issue(s)
Closes #4918