feat: add retry mechanism on dataflow completion #4914
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@correiaafonso12 please do not raise dangling PRs. there should be a properly triaged (!) issue accompanying (=linked to) this. |
Contributor
Author
Added the original issue in the description. Omitted it initially as it is already closed due to the PR for the decision record. |
ndr-brt
reviewed
Apr 10, 2025
...est/java/org/eclipse/edc/connector/dataplane/framework/manager/DataPlaneManagerImplTest.java
Outdated
Show resolved
Hide resolved
...est/java/org/eclipse/edc/connector/dataplane/framework/manager/DataPlaneManagerImplTest.java
Outdated
Show resolved
Hide resolved
...est/java/org/eclipse/edc/connector/dataplane/framework/manager/DataPlaneManagerImplTest.java
Outdated
Show resolved
Hide resolved
Member
|
@correiaafonso12 you can add me as a PR sponsor in the PR description |
correiaafonso12
force-pushed
the
feature/add-retry-mechanism-on-dataflow-completion
branch
from
820d0d4 to
163de68
Compare
correiaafonso12
force-pushed
the
feature/add-retry-mechanism-on-dataflow-completion
branch
from
163de68 to
534ea20
Compare
correiaafonso12
deleted the
feature/add-retry-mechanism-on-dataflow-completion
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Applies a retry mechanism in the
DataFlowManagerImplwhen processing theDataflow's COMPLETED and FAILED statesWhy it does that
After the data transfer, the
DataFlowtransitions to either COMPLETED or FAILED depending on whether the transfer succeeded or failed. In either case, the data plane notifies the control plane of the transfer outcome. If this notification fails, theDataFlowtransitions to its current state, causing the state machine manager to pick it up again and retry the process. Since there is no limit to the number of retries, this process could potentially continue forever.Further notes
Check this DR for more information: https://github.com/eclipse-edc/Connector/tree/main/docs/developer/decision-records/2025-03-17-retry-processor-on-dataflow-completion
Who will sponsor this feature?
@ndr-brt
Linked Issue(s)
Relates to #4860
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.