fix: add runtime-core module to base-BOMs #4911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
added
bug
wolf4ood
approved these changes
Apr 10, 2025
ndr-brt
reviewed
Apr 10, 2025
Member
ndr-brt
left a comment
ndr-brt
left a comment
There was a problem hiding this comment.
@paullatzelsperger late to the party but, could we revert this commit?
Comment on lines
26
to
+28
| api(project(":core:common:runtime-core")) | ||
| api(project(":core:common:token-core")) | ||
| api(project(":core:common:runtime-core")) |
paullatzelsperger
added a commit
that referenced
this pull request
Apr 10, 2025
This reverts commit 3e22ade.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
adds the new runtime-core module to the base BOMs
Why it does that
prevent runtime DI errors
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Who will sponsor this feature?
Please @-mention the committer that will sponsor your feature.
Linked Issue(s)
Closes # <-- insert Issue number if one exists
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.