fix: add lazy fetch for ObjectMapper in the json-ld context #4737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolf4ood
force-pushed
the
fix/4734_jsonld_object_mapper
branch
from
9d224fa to
aba67ee
Compare
wolf4ood
force-pushed
the
fix/4734_jsonld_object_mapper
branch
3 times, most recently
from
c5236ba to
aa021ce
Compare
wolf4ood
requested review from
bscholtes1A,
jimmarino,
juliapampus,
ndr-brt,
paullatzelsperger and
ronjaquensel
as code owners
paullatzelsperger
previously approved these changes
Jan 20, 2025
ndr-brt
reviewed
Jan 20, 2025
Member
ndr-brt
left a comment
ndr-brt
left a comment
There was a problem hiding this comment.
this looks to be a consistent change in core modules, a DR would be appreciated
Contributor
Author
|
On a second though this reduce the impact of the changes, but it will limit the extensibility of the |
wolf4ood
force-pushed
the
fix/4734_jsonld_object_mapper
branch
4 times, most recently
from
5ecdab7 to
1d15334
Compare
wolf4ood
changed the title
wolf4ood
changed the title
wolf4ood
changed the title
wolf4ood
changed the title
wolf4ood
changed the title
Contributor
Author
|
I've re-target the PR to not change the usage of |
wolf4ood
dismissed
paullatzelsperger’s stale review
The PR solution has changed, and it needs to be reviewed
wolf4ood
requested review from
paullatzelsperger
and removed request for
paullatzelsperger
paullatzelsperger
approved these changes
Jan 21, 2025
ndr-brt
approved these changes
Jan 21, 2025
| } | ||
| }; | ||
| mapper.registerModule(module); | ||
| mapper.enable(DeserializationFeature.ACCEPT_SINGLE_VALUE_AS_ARRAY); |
Member
There was a problem hiding this comment.
should this be part of a separate PR for the sake of clarity? It could also deserve a test
Contributor
Author
There was a problem hiding this comment.
This was already present in the code base, I just move it here centrally.
A test make sense 👍
wolf4ood
force-pushed
the
fix/4734_jsonld_object_mapper
branch
2 times, most recently
from
7f9bfd7 to
14cb168
Compare
wolf4ood
force-pushed
the
fix/4734_jsonld_object_mapper
branch
from
14cb168 to
704652e
Compare
jimmarino
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Adds lazy fetch of ObjectMapper for JSON-LD context from the
TypeManager.Why it does that
Fix possible wrong
ObjectMapperfetched in the initialize phaseFurther notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Closes #4734
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.