fix: transfer type resolution on dp self registration #4687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@paullatzelsperger as reviewer as well since he implemented the bi-directional channel feature. |
|
This pull request is stale because it has been open for 7 days with no activity. |
|
This pull request was closed because it has been inactive for 7 days since being marked as stale. |
rafaelmag110
force-pushed
the
fix_dataplane_transfertype
branch
from
168c5b8 to
2b7df74
Compare
rafaelmag110
force-pushed
the
fix_dataplane_transfertype
branch
from
2b7df74 to
d6116fc
Compare
paullatzelsperger
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
The responseType is now concatenated to the transferType as expected.
Why it does that
It was not being correctly concatenated.
Further notes
Also fixed some code docs lying around that had "HttpData-PULL/Websocket"
Linked Issue(s)
Closes #4686