fix: package declaration of JtiValidationStore #4623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolf4ood
approved these changes
Nov 13, 2024
paullatzelsperger
force-pushed
the
fix/package_declaration
branch
from
d83a7e7 to
07f212d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This fixes the package declaration of the JTI validation store
Why it does that
it had a wrong package declaration, which causes confusion, and more importantly, causes runtime errors
Further notes
specifically, the class
org.eclipse.edc.edr.store.index.sql.schema.postgres.PostgresDialectStatementsexisted twice on the classpath, but one was now updated to beorg.eclipse.edc.jtivalidation.store.index.sql.schema.postgres.PostgresDialectStatementsLinked Issue(s)
Closes # <-- insert Issue number if one exists
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.