Skip to content

Conversation

@ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Nov 5, 2024

What this PR changes/adds

Cleanup 0.6.x deprecations, except the ones on DataPlaneInstances, because they are bound to the management api (ref. #4578).

Details:

  • removed auth-basic module
  • removed canHandle method from DataSourceFactory and DataSinkFactory
  • removed mapTo methods from Result (replaced by mapEmpty and mapFailure)
  • removed getUuid method from PolicyDefinition
  • removed unused select methods from DataPlaneSelectorService
  • cleaned up some e2e test methods

Why it does that

cleanup

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes # <-- insert Issue number if one exists

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added refactoring Cleaning up code and dependencies breaking-change Will require manual intervention for version update labels Nov 5, 2024
@ndr-brt ndr-brt requested a review from wolf4ood November 5, 2024 09:56
@ndr-brt ndr-brt force-pushed the cleanup-0.6.x-deprecations branch from be42593 to 9e3d9b8 Compare November 5, 2024 14:41
Copy link
Contributor

@jimmarino jimmarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪓 🩸

@jimmarino jimmarino self-requested a review November 5, 2024 15:01
@ndr-brt ndr-brt merged commit c5dbf9d into eclipse-edc:main Nov 5, 2024
@ndr-brt ndr-brt deleted the cleanup-0.6.x-deprecations branch November 5, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change Will require manual intervention for version update refactoring Cleaning up code and dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants