Skip to content

Conversation

@jimmarino
Copy link
Contributor

What this PR changes/adds

Fixes for:

  • ConsumerContractNegotiationManagerImpl.processAccepting did not pass the current Policy as part of the RemoteMessage when dispatching, causing an NPE during policy evaluation.
  • JsonObjectToPolicyTransformer did not deserialize assignee and assigner if the policy type is an agreement, which is required by DSP
  • DspHttpRemoteMessageDispatcherImpl did not report the HTTP error code
  • DspRequestHandlerImpl reported the incorrect validation context
  • ContractNegotiation did not allow for a valid state transition (OFFERED)
  • ContractNegotistion should not allow transitions from FINALIZED to TERMINATED

Linked Issue(s)

Closes #4543

@jimmarino jimmarino added bug Something isn't working dataspace-protocol related to the dataspace protocol labels Oct 13, 2024
@jimmarino jimmarino marked this pull request as ready for review October 13, 2024 08:40
@jimmarino jimmarino merged commit d7b4222 into eclipse-edc:main Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working dataspace-protocol related to the dataspace protocol

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dsp: fixes related to DSP conformance

2 participants