feat: add component ID #4402
Merged
feat: add component ID #4402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
requested review from
bscholtes1A and
jimmarino
as code owners
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4402 +/- ##
==========================================
+ Coverage 71.74% 74.97% +3.23%
==========================================
Files 919 1072 +153
Lines 18457 21455 +2998
Branches 1037 1171 +134
==========================================
+ Hits 13242 16086 +2844
- Misses 4756 4848 +92
- Partials 459 521 +62 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ndr-brt
reviewed
Aug 8, 2024
core/common/boot/src/main/java/org/eclipse/edc/boot/system/DefaultServiceExtensionContext.java
Outdated
Show resolved
Hide resolved
ndr-brt
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This PR adds the
edc.component.idproperty with the following logic:edc.runtime.idis configured, a warning is issuededc.component.idis not configured, a warning is issued.edc.runtime.idis configured, its value is used foredc.component.id, andedc.runtime.idreceives a random UUIDedc.runtime.idis not configured, a random UUID is used foredc.component.idThis way, backwards compatibility can be provided for deployments that previously had configured a static
edc.runtime.id.In addition, Dataplane Self Registration was modified to use the
edc.component.idproperty.Why it does that
component IDs are used for idempotent processes, such as data plane registration. runtime IDs are used for lease acquisition.
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Closes #4399
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.