Implements RBAC Authorization for AASRepository #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes AasEnv docker build failure issue Signed-off-by: Mohammad Ghazanfar Ali Danish <[email protected]>
Signed-off-by: Mohammad Ghazanfar Ali Danish <[email protected]>
Signed-off-by: Mohammad Ghazanfar Ali Danish <[email protected]>
Signed-off-by: Mohammad Ghazanfar Ali Danish <[email protected]>
Closed
|
|
||
| private Logger logger = LoggerFactory.getLogger(PermissionResolver.class); | ||
|
|
||
| private InMemoryAuthorizationRbacStorage rbacStorage; |
Member
There was a problem hiding this comment.
I would expect RbacStorage here
Member
Author
There was a problem hiding this comment.
Addressed this in the latest commit.
| */ | ||
| @Service | ||
| @ConditionalOnExpression(value = "${" + CommonAuthorizationConfig.ENABLED_PROPERTY_KEY + ":false} and ('${" + CommonAuthorizationConfig.JWT_BEARER_TOKEN_PROVIDER_PROPERTY_KEY + "}'.equals('keycloak') or '${" + CommonAuthorizationConfig.JWT_BEARER_TOKEN_PROVIDER_PROPERTY_KEY + "}'.isEmpty())") | ||
| public class SubjectInformationFromSecurityContextProvider implements SubjectInformationProvider<Object> { |
Member
There was a problem hiding this comment.
Keycloak specific, maybe add in the class name?
Member
Author
There was a problem hiding this comment.
Addressed this in the latest commit.
| * | ||
| * @author danish | ||
| */ | ||
| public class PermissionResolver<T extends TargetInformation> { |
Member
Author
There was a problem hiding this comment.
Addressed this in the latest commit.
Signed-off-by: Mohammad Ghazanfar Ali Danish <[email protected]>
Signed-off-by: Mohammad Ghazanfar Ali Danish <[email protected]>
Signed-off-by: Mohammad Ghazanfar Ali Danish <[email protected]>
Signed-off-by: Mohammad Ghazanfar Ali Danish <[email protected]>
Member
|
Approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mohammad Ghazanfar Ali Danish [email protected]