Ensure to retrieve and display up-to-date publisher agreement status #1445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netomi
force-pushed
the
fix-publisher-agreement
branch
from
bb3f6c5 to
538340c
Compare
…gs and fixes, adjust and add more unit tests
Contributor
Author
|
Additionally the PR does some minor cleanups in the |
netomi
changed the title
Contributor
Author
|
Previously we were using different ways to retrieve the publisher agreement status depending on the task, leading to misalignment and confusion:
|
Contributor
Author
|
could you take a look @autumnfound ? |
…failed due to a 400 response
This was referenced Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1439.
This change ensures that the information whether a user has signed the publisher agreement is as up-to-date as possible. In the past, a user was signing in the open-vsx.org, login with the eclipse account and sign the agreement. It was then displayed like this in the app as the token was present and valid, but when publishing an extension, the public profile was used, which was still returning cached data that indicated that the user did not sign the publisher agreement. This lead to lots of confusion and frustration. In the meantime the cache has been reduced to 5 min from 15 min previously.
With this change, when a user signs in to open-vsx.org, the following happens:
This happens both, for displaying the publisher agreement status in the app (via the
/userendpoint), as well as when checking whether the publisher has a valid publisher agreement when publishing an extension.