Add configuration setting to disable automatic storage migration #1425
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM - @amvanbaren - At your earliest convivence, can you take a look at this please? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to specify a configuration option
osvx.storage.migration.enabledto explicitly disable the automatic storage migration in case the primary storage type has changed.If this option is not specified it behaves as before, enabling the storage migration if mirror mode is disabled.
The reasoning for this change is that the existing storage migration only runs sequentially and for a large instance of openvsx it will be impractical so we want to explicitly disable the automatic migration to perform it manually while still be able to set the primary storage type to another one.
For the change also the wiki page about the deployment needs to be adapted to document this new setting.