Skip to content

Conversation

@syluna
Copy link
Contributor

@syluna syluna commented Sep 10, 2024

Separate check :

  • width for scroll horizontal
  • height for scroll vertical

Copy link
Owner

@eckig eckig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust the formatting (braces on new line).

Copy link
Owner

@eckig eckig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all thanks for looking into this.

Since this does not compile, I just have to ask: Did you try this? :)

contentY.set(newY);
}
panToX(x);
panToY(y)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a ;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arf no I can't test directly my env is set for my works so I can't change this. I just copy/past my change in web editor to apply the change.

Sorry....

fix missing semi colon
Copy link
Contributor Author

@syluna syluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix semi colon

@eckig eckig merged commit 70d4089 into eckig:master Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants