CI: Add HTML validation to super-linter workflow#303
Open
Conversation
|
Would you mind to rebase this to see if the superlinter is happy now? |
Owner
Author
|
@neteler Done |
Owner
Author
|
@neteler theres still some. The one where you changed There's two unexpected closing div. Sometimes it's that a bit above a closing tag is interweaved instead of nested. |
|
I am preparing a big PR with tons of HTML fixes. Coming soon. |
neteler
added a commit
to OSGeo/grass
that referenced
this pull request
Nov 27, 2024
In order to obtain a good result when converting the HTML manual pages files to markdown, ideally clean HTML code is used. This PR fixes numerous broken HTML tags identified during a test run of [adding HTML validation with super-linter](echoix#303). For reference, see logs showing the errors at https://github.com/echoix/grass/actions/runs/12001379426/job/33451802353?pr=303#step:4:8310 Fixes: - incomplete tag pairs - tabs replaced with white space - fix missing .html extension in URLs
Merged in |
Owner
Author
In progress |
Owner
Author
ok, i skipped a lot and it’s starting to be big. |
|
I will improve further selected HTML bugs but
|
|
BTW: I wonder if the super-linter might better look at the final manual pages (i.e., the files generated during the compilation)? |
Owner
Author
Super-linter probably not, as it works better with committed files. Maybe running the tools directly once compiled/generated? But it might only be useful to run linters on generated files when developing, not ongoing use. Unless there's a point/argument I don't consider. |
|
Next brushup (hope the last): OSGeo#4781 |
echoix
added a commit
to OSGeo/grass
that referenced
this pull request
Nov 28, 2024
* manual: fix more broken HTML tags In order to obtain a good result when converting the HTML manual pages files to markdown, ideally clean HTML code is used (continuation of #4765). This PR fixes numerous broken HTML tags identified during a test run of [adding HTML validation with super-linter](echoix#303). For reference, see logs showing the errors at https://github.com/echoix/grass/actions/runs/12067630007/job/33651008404?pr=303 Fixes include: - complete selected ncomplete tag pairs (esp. `<li>`) - tabs replaced with white space - `<`, `>`, `&` replaced with their HTML representations * Apply suggestions from code review --------- Co-authored-by: Edouard Choinière <[email protected]>
neteler
added a commit
to OSGeo/grass
that referenced
this pull request
Nov 30, 2024
Backport of #4765 In order to obtain a good result when converting the HTML manual pages files to markdown, ideally clean HTML code is used. This PR fixes numerous broken HTML tags identified during a test run of [adding HTML validation with super-linter](echoix#303). For reference, see logs showing the errors at https://github.com/echoix/grass/actions/runs/12001379426/job/33451802353?pr=303#step:4:8310 Fixes: - incomplete tag pairs - tabs replaced with white space - fix missing .html extension in URLs
neteler
added a commit
to OSGeo/grass
that referenced
this pull request
Nov 30, 2024
* manual: fix more broken HTML tags In order to obtain a good result when converting the HTML manual pages files to markdown, ideally clean HTML code is used (continuation of #4765). This PR fixes numerous broken HTML tags identified during a test run of [adding HTML validation with super-linter](echoix#303). For reference, see logs showing the errors at https://github.com/echoix/grass/actions/runs/12067630007/job/33651008404?pr=303 Fixes include: - complete selected ncomplete tag pairs (esp. `<li>`) - tabs replaced with white space - `<`, `>`, `&` replaced with their HTML representations * Apply suggestions from code review --------- Co-authored-by: Edouard Choinière <[email protected]>
|
I have used your latest run to identify further HTML errors (ignoring Fixed in OSGeo@2419487 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.