Skip to content

Commit b921dab

Browse files
committed
fix: retry failed LSP servers with exponential backoff (anomalyco#13785)
1 parent 1d041c8 commit b921dab

1 file changed

Lines changed: 31 additions & 7 deletions

File tree

‎packages/opencode/src/lsp/index.ts‎

Lines changed: 31 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,30 @@ import { Flag } from "@/flag/flag"
1414
export namespace LSP {
1515
const log = Log.create({ service: "lsp" })
1616

17+
const LSP_RETRY_MAX = 5
18+
const LSP_RETRY_BASE_MS = 30_000
19+
20+
interface BrokenEntry {
21+
count: number
22+
until: number
23+
}
24+
25+
function markBroken(broken: Map<string, BrokenEntry>, key: string) {
26+
const prev = broken.get(key)
27+
const count = prev ? prev.count + 1 : 1
28+
const until = count > LSP_RETRY_MAX ? Infinity : Date.now() + LSP_RETRY_BASE_MS * Math.pow(2, count - 1)
29+
broken.set(key, { count, until })
30+
return { count, until }
31+
}
32+
33+
function isBroken(broken: Map<string, BrokenEntry>, key: string): boolean {
34+
const entry = broken.get(key)
35+
if (!entry) return false
36+
if (entry.until === Infinity) return true
37+
if (Date.now() < entry.until) return true
38+
return false
39+
}
40+
1741
export const Event = {
1842
Updated: BusEvent.define("lsp.updated", z.object({})),
1943
}
@@ -85,7 +109,7 @@ export namespace LSP {
85109
if (cfg.lsp === false) {
86110
log.info("all LSPs are disabled")
87111
return {
88-
broken: new Set<string>(),
112+
broken: new Map<string, BrokenEntry>(),
89113
servers,
90114
clients,
91115
spawning: new Map<string, Promise<LSPClient.Info | undefined>>(),
@@ -132,7 +156,7 @@ export namespace LSP {
132156
})
133157

134158
return {
135-
broken: new Set<string>(),
159+
broken: new Map<string, BrokenEntry>(),
136160
servers,
137161
clients,
138162
spawning: new Map<string, Promise<LSPClient.Info | undefined>>(),
@@ -183,11 +207,11 @@ export namespace LSP {
183207
const handle = await server
184208
.spawn(root)
185209
.then((value) => {
186-
if (!value) s.broken.add(key)
210+
if (!value) markBroken(s.broken, key)
187211
return value
188212
})
189213
.catch((err) => {
190-
s.broken.add(key)
214+
markBroken(s.broken, key)
191215
log.error(`Failed to spawn LSP server ${server.id}`, { error: err })
192216
return undefined
193217
})
@@ -200,7 +224,7 @@ export namespace LSP {
200224
server: handle,
201225
root,
202226
}).catch((err) => {
203-
s.broken.add(key)
227+
markBroken(s.broken, key)
204228
handle.process.kill()
205229
log.error(`Failed to initialize LSP client ${server.id}`, { error: err })
206230
return undefined
@@ -226,7 +250,7 @@ export namespace LSP {
226250

227251
const root = await server.root(file)
228252
if (!root) continue
229-
if (s.broken.has(root + server.id)) continue
253+
if (isBroken(s.broken, root + server.id)) continue
230254

231255
const match = s.clients.find((x) => x.root === root && x.serverID === server.id)
232256
if (match) {
@@ -268,7 +292,7 @@ export namespace LSP {
268292
if (server.extensions.length && !server.extensions.includes(extension)) continue
269293
const root = await server.root(file)
270294
if (!root) continue
271-
if (s.broken.has(root + server.id)) continue
295+
if (isBroken(s.broken, root + server.id)) continue
272296
return true
273297
}
274298
return false

0 commit comments

Comments
 (0)