Conversation
ebkr
force-pushed
the
deck
branch
5 times, most recently
from
65b3b42 to
aeb54e5
Compare
anttimaki
reviewed
Jan 9, 2026
| return { | ||
| moddedParameters: `--gdweave-folder-override="${DynamicGameInstruction.GDWEAVE_FOLDER}"`, | ||
| vanillaParameters: "--gdweave-disable" | ||
| moddedParameterList: [`--gdweave-folder-override=${DynamicGameInstruction.GDWEAVE_FOLDER}`], |
Collaborator
There was a problem hiding this comment.
The quotes were intentionally added here so ensure removing them doesn't break things.
Owner
Author
There was a problem hiding this comment.
The behaviour should be almost identical
We go from:
-: --gdweave-folder-override="some path"
+: "--gdweave-folder-override=some path"Both are almost entirely similar, however this new way prevents all arg parsers from reading " as part of one of the value.
Compared to the original reason, we'd end up with:
-: --gdweave-folder-override=some path
+: "--gdweave-folder-override=some path"and this would have been done so that the command was treated as a single entry.
I haven't tested with GDWeave, but in general, a quote surrounded argument is handled correctly.
Collaborator
|
Can confirm that this works on my Steam deck |
- Game instructions are now passed as lists - All game runners need to support this (currently only SteamGameRunner_Linux.ts does) - Additional launch arguments setting needs to be reworked to implement a key/value approach
…ntry. - Refactored env.FLATPAK_ID to a reusable util - Text fixes - Better argument conflict detection - Force enters native setup if args aren't provided on Flatpak (regardless of Proton)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steam Deck / Flatpak Support
This PR adds Flatpak building potential to r2modman which allows native installing to the deck (and running in Game Mode).
Status
As of now, this branch can be built to a Flatpak image and it will run.
It has currently broken launching of every other platform. Works great if you're on Steam Deck - not if you're a regular user.
Differences
Flatpak has an absolute ton of restrictions. To work around this for Flatpak-based installs we now do the following:
steam://run/<appid>.Extra changes
I've taken out the automated file modifications to enable WINEDLLOVERRIDES. Instead we are now making the user supply the override as an environment variable as it's more reliable. This is done as part of the launch arguments copyable string.
Users will be prompted if their launch args don't match. For existing launches they'll already have the file modified so it won't affect older users regardless of the re-prompt.