Make NodePathProvider::resolve variadic#1983
Merged
ebkr merged 1 commit intoebkr:developfrom Nov 18, 2025
Merged
Conversation
The associated node function is variadic, and this is assumed by the linux path management. I think this partially fixes ebkr#1963, although on my local system there's another issue preventing Linux from working.
Owner
|
Could you elaborate on how exactly this would fix the linked issue? I don't believe this is needed, as it works on an application restart as mentioned which suggests it's an odd runtime env bug, rather than a resolve bug. |
Contributor
Author
|
const dirs = [
path.resolve(os.homedir(), '.local', 'share', 'Steam'),
path.resolve(os.homedir(), '.steam', 'steam'),
path.resolve(os.homedir(), '.steam', 'root'),
path.resolve(os.homedir(), '.steam'),
path.resolve(os.homedir(), '.var', 'app', 'com.valvesoftware.Steam', '.local', 'share', 'Steam'),
path.resolve(os.homedir(), '.var', 'app', 'com.valvesoftware.Steam', '.steam', 'steam'),
path.resolve(os.homedir(), '.var', 'app', 'com.valvesoftware.Steam', '.steam', 'root'),
path.resolve(os.homedir(), '.var', 'app', 'com.valvesoftware.Steam', '.steam')
];As the Once it is set manually (and apparently after a restart?) this autodiscovery is skipped in favour of the value in the preferences. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The associated node function is variadic, and this is assumed by the linux path management.
I think this partially fixes #1963, although on my local system there's another issue preventing Linux from working.