Conversation
VilppeRiskidev
force-pushed
the
cover-image-optimization
branch
2 times, most recently
from
0d1e3c3 to
b61d2f1
Compare
Collaborator
Author
|
thunderstore-io/ecosystem-schema#192 Generating the schema from this version of ecosystem-schema repo seems to work with these changes. |
VilppeRiskidev
force-pushed
the
cover-image-optimization
branch
from
b61d2f1 to
8cba02d
Compare
Collaborator
Author
|
game_selection folder total size went from 9,68MB to 4,83MB |
anttimaki
approved these changes
Aug 21, 2025
Collaborator
anttimaki
left a comment
anttimaki
left a comment
There was a problem hiding this comment.
- I'm still unsure why bash scripts were chosen for this task, but if it works it works
assets/imagesseems like a wrong place for the script files. Could the perhaps be moved to e.g./scriptswithout breaking them?
VilppeRiskidev
force-pushed
the
cover-image-optimization
branch
from
ea93eca to
668fe6e
Compare
VilppeRiskidev
force-pushed
the
cover-image-optimization
branch
from
668fe6e to
36bc034
Compare
anttimaki
requested changes
Aug 27, 2025
Collaborator
anttimaki
left a comment
anttimaki
left a comment
There was a problem hiding this comment.
Uh, the new changes are fine but I probably should've noticed this in the earlier review already: dropping the webp convertor script might be a mistake, as having a script that just renames image files without actually converting them seems like a bad idea. So if we want to keep the scripts around for future use, we should either keep both convert/rename, or combine them into one that converts and renames non-webp files at one go.
VilppeRiskidev
force-pushed
the
cover-image-optimization
branch
2 times, most recently
from
169b433 to
0852a2f
Compare
* Add and run auto-renaming script and run it for the images * Add and run a script which converts all of the cover images to webp * Perform a few manual renames * Add a image name format validator script and delete unneeded scripts
VilppeRiskidev
force-pushed
the
cover-image-optimization
branch
from
0852a2f to
3e6bd83
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.