Config Editor: Multi Select#1855
Merged
ebkr merged 4 commits intoconfig-editor/cleanupfrom Sep 26, 2025
Merged
Conversation
anttimaki
approved these changes
Aug 15, 2025
|
|
||
| const configurationFile = ref<ConfigurationFile | null>(null); | ||
| const configurationFileHolder = reactive({ | ||
| configurationFile: {} as ConfigurationFile, |
Collaborator
There was a problem hiding this comment.
Is this for future proofing, or why is the configurationFile the only entry in a wrapper object, instead of it being the object passed to reactive()?
Owner
Author
There was a problem hiding this comment.
It's a Vue 2 quirk - reactive wasn't behaving as intended without the wrapper object. I can't quite remember why, but we were also getting warnings with it too.
In theory the migration to Vue 3 would resolve this issue and we can remove the wrapper.
ebkr
force-pushed
the
config-editor/cleanup
branch
from
7e8cba2 to
243a7c1
Compare
ebkr
force-pushed
the
config-editor/multi-select
branch
from
f8497e1 to
3fcea42
Compare
ebkr
force-pushed
the
config-editor/cleanup
branch
from
0b7e719 to
2b28661
Compare
ebkr
force-pushed
the
config-editor/multi-select
branch
from
3fcea42 to
37ba0e2
Compare
ebkr
force-pushed
the
config-editor/cleanup
branch
from
4cf2973 to
e772195
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we had shown these as a text field, requiring people to enter the config text in manually.
Is it worth also having a text field toggle? I can't see a huge benefit although people may still want it? Thoughts?