Conversation
anttimaki
requested changes
Aug 14, 2025
Collaborator
anttimaki
left a comment
anttimaki
left a comment
There was a problem hiding this comment.
Beside the tsmm/test related issues, which I consider blocker, I've only some small nitpicky things to say. Based on quick manual testing seems to work as expected.
ebkr
force-pushed
the
config-editor/cleanup
branch
from
7e8cba2 to
243a7c1
Compare
anttimaki
approved these changes
Sep 3, 2025
ebkr
force-pushed
the
config-editor/cleanup
branch
from
0b7e719 to
2b28661
Compare
…re value whitespaces.
- Short refactor to reduce dependency on old ConfigFile
- Changes to ConfigEntryEditor.vue to keep sticky section titles
ebkr
force-pushed
the
quasar-upgrade
branch
from
777cfe4 to
dad6801
Compare
ebkr
force-pushed
the
config-editor/cleanup
branch
from
4cf2973 to
e772195
Compare
Config Editor: Multi Select
itsschwer
added a commit
to itsschwer/ror2-huddle-up
that referenced
this pull request
Nov 21, 2025
r2modman's new config editor ( ebkr/r2modmanPlus#1854 ) filters out sections that have a name with a length of 0 (i.e. empty strings), so this can no longer used to order a section first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a rewrite of the config editor code to make it more maintained and extensible for future work.
Key changes:
Show moreaction now affects text length as well as line count making it more practical.Future changes:
This allows us to add features such as:
Screenshots