internal/input: add a workaround fix for touch controls on mobiles#101
Merged
mcarpenter622 merged 1 commit intoebitenui:masterfrom Mar 19, 2024
Merged
Conversation
Keep the last touch pos on mobile devices as opposed to resetting them to `(0, 0)` (since `ebiten.CursorPos` returns zeroes for mobiles). This fix would not be needed if events were handled in `Update()` tree instead of `Draw()` tree. For now, this is the easiest fix. Refs ebitenui#100
Collaborator
|
So this looks like it should be fine, I think I wanna test it a bit more and maybe make a few cleanup changes (your todos). I can merge this now if you need it for you game @quasilyte but I'd prefer to play with it a little more. |
Contributor
Author
|
Let's play with it longer then! |
mcarpenter622
approved these changes
Mar 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep the last touch pos on mobile devices as opposed to resetting them to
(0, 0)(sinceebiten.CursorPosreturns zeroes for mobiles).This fix would not be needed if events were handled in
Update()tree instead ofDraw()tree. For now, this is the easiest fix.Refs #100