Adds group by country in advance settings #373
Conversation
gabrielysimette
force-pushed
the
feature/checkout-options-by-country
branch
from
b84d369 to
466832b
Compare
|
|
||
| var updateFields = function(){ | ||
| var modes = modesField.val(); | ||
| var brazil_val = countryPayments.brazil.val(); |
There was a problem hiding this comment.
In JS, we are using camelCase to variables and methods names.
| for (var i in modes) { | ||
| enableFields(fields.filter('.' + modes[i])); | ||
| } | ||
| if (modes.length == 2) { |
There was a problem hiding this comment.
Why 2? Is there a automatically way to do this? It's dangerous put this in hard code haha
There was a problem hiding this comment.
It's two because when CPF and CNPJ are both selected the field "Entity Type Selector" is added.
| 'title' => __('RUT', 'woocommerce-gateway-ebanx'), | ||
| 'type' => 'text', | ||
| 'class' => 'ebanx-advanced-option ebanx-checkout-manager-field always-visible', | ||
| 'class' => 'ebanx-advanced-option ebanx-checkout-manager-field chile', |
There was a problem hiding this comment.
Can we change the class to something like ebanx-chile-document? Because chile is so generic and can cause troubles with another plugins, etc.
| 'title' => __('Brazil', 'woocommerce-gateway-ebanx'), | ||
| 'type' => 'multiselect', | ||
| 'class' => 'ebanx-select', | ||
| 'class' => 'ebanx-select payment-method', |
There was a problem hiding this comment.
Can we change the class to ebanx-payment-method?
There was a problem hiding this comment.
We realize that it was not being used so we just removed it.
|
@gpressutto5 Yes, I agree. Because we may need to add the Colombia fields, because Colombia has the DNI and the flow will be the same. @gabrielysimette hold this PR. |
|
@gabrielysimette we merged the |
…into feature/checkout-options-by-country
|
@gpressutto5 will test your branch and if all is ok, you can merge, just wait his approval. |
|
I think we should also hide the checkout manager option when it is empty. Check this out: |
|
@gabrielysimette can you solve the @gpressutto5 request? |
…ll checkout manager fields would disappear
Closes #307