[HOTFIX] Rewrote address splitting function to work with bad addresses #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cezarsmpio
suggested changes
Mar 15, 2017
| * and additionToAddress2 contain additional information that is given at the start and the end of the string, respectively. | ||
| * Unit tests for testing the regular expression that this function uses exist over at https://regex101.com/r/vO5fY7/1. | ||
| * More information on this functionality can be found at http://blog.viison.com/post/115849166487/shopware-5-from-a-technical-point-of-view#address-splitting. | ||
| * Fatia um endereço em nome da rua, número e complemento |
| * Fatia um endereço em nome da rua, número e complemento | ||
| * | ||
| * @param string $address | ||
| * @param string $address Endereço a ser fatiado |
| \s*\Z/xu'; | ||
|
|
||
| $result = preg_match($regex, $address, $matches); | ||
| public static function split_street($address) { |
There was a problem hiding this comment.
Are you really right about this? There is a huge difference between the regexs... Why this?
Contributor
Author
There was a problem hiding this comment.
That regex was not working when address had no number... a merchant added an address number field to their checkout (using checkout manager) and that broke things as address had no number and regex simply failed...
As it was too complex we rewrote the regex to be simplier and to match with weird addresses anyway.
| } elseif ($result === false) { | ||
| throw new \RuntimeException(sprintf('Error occurred while trying to split address \'%s\'', $address)); | ||
| if ($result === false) { | ||
| throw new \RuntimeException(sprintf('Problemas ao interpretar o endereço: \'%s\'', $address)); |
There was a problem hiding this comment.
The string is in pt-br, please, put in en-us.
cezarsmpio
approved these changes
Mar 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bad addresses with missing numbers broke the checkout page.